Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support URL prefix for reference links in Markdown files, fixes #8588 #8607

Merged
merged 2 commits into from
Oct 2, 2018
Merged

Support URL prefix for reference links in Markdown files, fixes #8588 #8607

merged 2 commits into from
Oct 2, 2018

Conversation

i-like-robots
Copy link
Contributor

This is a small change to the gatsby-transformer-remark plugin to add support for URL prefixes to reference style links in Markdown files. Full description in #8588.

@pieh
Copy link
Contributor

pieh commented Sep 28, 2018

Could you add test for that in https://github.com/gatsbyjs/gatsby/blob/master/packages/gatsby-transformer-remark/src/__tests__/extend-node.js ? (you would need to edit bootstrapTest function to allow passing pathPrefix there)

@i-like-robots
Copy link
Contributor Author

@pieh test added, I'm afraid I don't know how to fix the Netlify deploy step - I'm assuming that is just flaky sometimes?

@pieh
Copy link
Contributor

pieh commented Oct 1, 2018

Don't worry about netlify - it is flaky unfortunately - circleCi tests are one we rely on the most

Copy link
Contributor

@pieh pieh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @i-like-robots!

@pieh pieh merged commit fb43fda into gatsbyjs:master Oct 2, 2018
@gatsbot
Copy link

gatsbot bot commented Oct 2, 2018

Holy buckets, @i-like-robots — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. (Currently we’ve got a couple t-shirts available, plus some socks that are really razzing our berries right now.)
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. You’ll receive an email shortly asking you to confirm. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants